From: Dave Chinner <david@fromorbit.com>
To: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Cc: sandeen@redhat.com, viro@zeniv.linux.org.uk, swhiteho@redhat.com,
tytso@mit.edu, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, zohar@linux.vnet.ibm.com
Subject: Re: [PATCH 1/1] fiemap: move i_op->fiemap() locking to the ioctl_fiemap()
Date: Sat, 22 Sep 2012 08:59:10 +1000 [thread overview]
Message-ID: <20120921225910.GB20960@dastard> (raw)
In-Reply-To: <a1259b2d9d0e9c0ee02f37f9b21230fcb9702207.1348236846.git.dmitry.kasatkin@intel.com>
On Fri, Sep 21, 2012 at 05:14:28PM +0300, Dmitry Kasatkin wrote:
> On some filesystems calling i_op->fiemap() takes the i_mutex,
> on others it doesn't.
Exactly by design. Many fiesystems don't require the i_mutex for
fiemap to be safe. e.g. the extent map is not protected by the
i_mutex in XFS or ext4, and so holding the i_mutex over fiemap is
incorrect.
As a result, extent maps can change even when someone is holding the
i_mutex. Any design that requires i_mutex to provide stable,
unchanging extent maps is fundamentally broken....
So that's a NACK from me...
> This change is needed in preparation for EVM to include a hash of
> the extent data to be used in the HMAC calculation. EVM is called
> when the i_mutex has already been taken.
What's EVM? What's HMAC? and what is it actually checksumming? The
extent map, or the data in the file? And if it is the extent map,
what's the purpose of using the extent map for this? You need to
explain how this is intended to be used, not use TLAs that people
unfamiliar with your application will not understand...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-09-21 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 14:14 [PATCH 1/1] fiemap: move i_op->fiemap() locking to the ioctl_fiemap() Dmitry Kasatkin
2012-09-21 14:27 ` Steven Whitehouse
2012-09-21 14:33 ` Kasatkin, Dmitry
2012-09-21 14:39 ` Steven Whitehouse
2012-09-21 22:59 ` Dave Chinner [this message]
2012-09-24 8:13 ` Kasatkin, Dmitry
2012-09-24 9:18 ` Dave Chinner
2012-09-24 11:28 ` Kasatkin, Dmitry
2012-09-25 1:56 ` Dave Chinner
2012-09-26 8:22 ` Kasatkin, Dmitry
2012-09-27 2:12 ` Dave Chinner
2012-09-27 7:43 ` Kasatkin, Dmitry
2012-09-27 12:35 ` Dave Chinner
2012-09-27 13:11 ` Kasatkin, Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921225910.GB20960@dastard \
--to=david@fromorbit.com \
--cc=dmitry.kasatkin@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).