From: Christoph Hellwig <hch@infradead.org>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH v2 3/4] hfsplus: rework functionality of getting, setting and deleting of extended attributes
Date: Wed, 26 Sep 2012 08:13:24 -0400 [thread overview]
Message-ID: <20120926121324.GA14912@infradead.org> (raw)
In-Reply-To: <1348570624.2033.59.camel@slavad-ubuntu-11>
On Tue, Sep 25, 2012 at 02:57:04PM +0400, Vyacheslav Dubeyko wrote:
> As I can understand, you are talking about using xattr_handler's for
> dispatching of processing of extended attributes with such complex names
> as "system.posix_acl_access" and so on. Am I correct?
>
> The HFS+ has such peculiarities that you can name extended attribute as
> you want. And name of extended attribute can keep in Attributes Tree
> without any prefixes (for example, as "test"). Moreover, it is not used
> such prefixes as "user." or "system." under Mac OS X.
But we will have to use them under Linux. The whole xattr mechanism
is built around the model that we decide policies, including most
importantly access control, based on these prefixes. In retrospective
I think the string prefixes are a horrible idea and a simple binary
flag namespace as done by e.g. IRIX or FreeBSD would have made everyones
life a heck lot simpler, but that's not what we implemented 10 years
ago.
> However, it exists under Mac OS X special prefix "com.apple." (for
> example, "com.apple.FinderInfo"). So, you suggest to add definition of
> additional prefixes "com." and "apple." in include/linux/xattr.h and to
> add xattr_handler's for these two prefixes. Am I correct?
No. I'd suggest mapping any free-form attributes in hfsplus into user.*
in the syscall namespace, while only mapping a few that needs special
treatment into system.* or similar. Using the proper helpers will make
this actually readable at least.
next prev parent reply other threads:[~2012-09-26 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 14:49 [PATCH v2 3/4] hfsplus: rework functionality of getting, setting and deleting of extended attributes Vyacheslav Dubeyko
2012-09-25 9:45 ` Christoph Hellwig
2012-09-25 10:57 ` Vyacheslav Dubeyko
2012-09-26 12:13 ` Christoph Hellwig [this message]
2012-09-26 14:20 ` Vyacheslav Dubeyko
2012-09-26 23:00 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926121324.GA14912@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=htl10@users.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).