From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/6] xfstests: add fio requirement V2 Date: Thu, 27 Sep 2012 10:19:59 +1000 Message-ID: <20120927001959.GE15236@dastard> References: <1348496601-32637-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de, xfs@oss.sgi.com To: Dmitry Monakhov Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:6068 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087Ab2I0AUL (ORCPT ); Wed, 26 Sep 2012 20:20:11 -0400 Content-Disposition: inline In-Reply-To: <1348496601-32637-1-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Sep 24, 2012 at 06:23:16PM +0400, Dmitry Monakhov wrote: > FIO is very flexible io generator, i would call it IO swiss knife. > Currently we have tonns of hardcoded application which reproduces > some predefined scenario. This approach has obvious dissadvantages > 1) Lack of flexability: one written it is hard to modify it in future > 2) Code base is large, many routines written again and again > > At the same time add new fio based tast is just add simle INI file. > This greatly simplify code review. I do beleve that some day we will > replace most of hardcoded io binaries with fio. > > One who is planning to run $FIO_PROG should first check that system > contains appropriate version which is able to handle jobfile > for example: _require_fio 286-job.fio > > Signed-off-by: Dmitry Monakhov Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com