From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v7 03/49] audit: no need to walk list in audit_inode if name is NULL Date: Tue, 2 Oct 2012 11:56:43 -0400 Message-ID: <20121002155643.GC22698@infradead.org> References: <1349137018-21948-1-git-send-email-jlayton@redhat.com> <1349137018-21948-4-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, eparis@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-audit@redhat.com To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1349137018-21948-4-git-send-email-jlayton@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Oct 01, 2012 at 08:16:12PM -0400, Jeff Layton wrote: > If name is NULL then the condition in the loop will never be true. Also, > with this change, we can eliminate the check for n->name == NULL since > the equivalence check will never be true if it is. Given that name == NULL is a static condition it seems like these should be two different calls, E.g. audit_dentry and audit_path.