* [PATCH 14/22] hostfs: drop vmtruncate
@ 2012-10-06 8:31 Marco Stornelli
2012-10-13 16:22 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Marco Stornelli @ 2012-10-06 8:31 UTC (permalink / raw)
To: Linux FS Devel, Al Viro
Cc: Jeff Dike, Richard Weinberger, user-mode-linux-devel,
user-mode-linux-user, linux-kernel
Removed vmtruncate.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/hostfs/hostfs_kern.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 6c9f3a9..4348e84 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -848,9 +848,11 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
attr->ia_size != i_size_read(inode)) {
int error;
- error = vmtruncate(inode, attr->ia_size);
- if (err)
- return err;
+ error = inode_newsize_ok(inode, attr->ia_size);
+ if (error)
+ return error;
+
+ truncate_setsize(inode, attr->ia_size);
}
setattr_copy(inode, attr);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 14/22] hostfs: drop vmtruncate
2012-10-06 8:31 [PATCH 14/22] hostfs: drop vmtruncate Marco Stornelli
@ 2012-10-13 16:22 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2012-10-13 16:22 UTC (permalink / raw)
To: Marco Stornelli
Cc: Linux FS Devel, Al Viro, Jeff Dike, Richard Weinberger,
user-mode-linux-devel, user-mode-linux-user, linux-kernel
> +++ b/fs/hostfs/hostfs_kern.c
> @@ -848,9 +848,11 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
> attr->ia_size != i_size_read(inode)) {
> int error;
>
> - error = vmtruncate(inode, attr->ia_size);
> - if (err)
> - return err;
> + error = inode_newsize_ok(inode, attr->ia_size);
> + if (error)
> + return error;
> +
> + truncate_setsize(inode, attr->ia_size);
The inode_change_ok call here is superflous, it's already done by
inode_change_ok at the beginning of the function. Even if that wasn't
done doing it aftet set_attr() would be too late anyway.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-13 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-06 8:31 [PATCH 14/22] hostfs: drop vmtruncate Marco Stornelli
2012-10-13 16:22 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).