From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] fsfreeze: tell hung_task about processes put to sleep Date: Mon, 15 Oct 2012 17:36:09 +1100 Message-ID: <20121015063608.GW2739@dastard> References: <1350035252.6500.2.camel@nexus.lab.ntt.co.jp> <20121013010613.GP2739@dastard> <507B820B.3000908@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Al Viro , Ingo Molnar , Jan Kara , linux-fsdevel@vger.kernel.org To: Fernando Luis Vazquez Cao Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:34514 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602Ab2JOGgP (ORCPT ); Mon, 15 Oct 2012 02:36:15 -0400 Content-Disposition: inline In-Reply-To: <507B820B.3000908@lab.ntt.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Oct 15, 2012 at 12:24:59PM +0900, Fernando Luis Vazquez Cao wro= te: > On 2012/10/13 10:06, Dave Chinner wrote: > >On Fri, Oct 12, 2012 at 06:47:32PM +0900, Fernando Luis V=E1zquez Ca= o wrote: > >>Any process attempting to write to a frozen filesystem uninterrupti= bly and > >>unkillably waits for the filesystem to be thawed. This wait is of u= nbounded > >>length. Ignore such waits in the hung_task detector. > >Filesystems should not be frozen for long enough to trigger the hung > >task detector under normal usage. IMO, if you are freezing a > >filesystem for that long, then you're either doing something wrong > >or something has gone wrong, and in either case I think we should be > >emitting warnings... >=20 > The problem is that in production systems situations where > a filesystem remains brozen for long periods are not uncommon. > A typical example is as follows: the control daemon or script that > controls the freeze/thaw using the fsfreeze ioctls dies, the next There's your problem. Fix that, don't turn off useful warnings that indicate something has gone wrong. Cheers, Dave. --=20 Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html