From: Christoph Hellwig <hch@infradead.org>
To: Chris Mason <chris.mason@fusionio.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [RFC, PATCH 0/2] fiemap: filesystem free space mapping
Date: Wed, 24 Oct 2012 11:09:51 -0400 [thread overview]
Message-ID: <20121024150951.GA24318@infradead.org> (raw)
In-Reply-To: <20121024114711.GB11262@shiny>
On Wed, Oct 24, 2012 at 07:47:17AM -0400, Chris Mason wrote:
> I'm all for it in the main fiemap call, it makes much more sense for the
> users I think.
How so? Current fiemap is a per-inode information, Daves new call is
per-fs. Making one a flag of another is a gross user interface. In
addition we're bound to get issue where filesystems fail to wire up
fiemap to the tons of different iops just for this operation, or
accidentally wire up "real" fiemap to things like special files or
pipes.
Btw, I'd like t orestate that I really love to see this functionality in
the VFS, just not multiplexed over FIEMAP.
next prev parent reply other threads:[~2012-10-24 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 5:11 [RFC, PATCH 0/2] fiemap: filesystem free space mapping Dave Chinner
2012-10-18 5:11 ` [PATCH 1/2] fiemap: add freespace mapping to FS_IOC_FIEMAP Dave Chinner
2012-11-08 16:50 ` Mark Tinguely
2012-11-08 20:56 ` Dave Chinner
2012-11-08 21:01 ` Mark Tinguely
2012-10-18 5:11 ` [PATCH 2/2] xfs: implement FIEMAP_FLAG_FREESPACE_* Dave Chinner
2012-10-18 5:27 ` [RFC, PATCH 3/2] xfsprogs: space management tool Dave Chinner
2012-10-18 8:10 ` [RFC, PATCH 0/2] fiemap: filesystem free space mapping Andreas Dilger
2012-10-18 21:07 ` Dave Chinner
2012-10-23 12:30 ` Christoph Hellwig
2012-10-23 21:53 ` Dave Chinner
2012-10-24 11:47 ` Chris Mason
2012-10-24 12:32 ` Jie Liu
2012-10-24 15:09 ` Christoph Hellwig [this message]
2012-10-24 19:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024150951.GA24318@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@fusionio.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).