From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC, PATCH 0/2] fiemap: filesystem free space mapping Date: Wed, 24 Oct 2012 11:09:51 -0400 Message-ID: <20121024150951.GA24318@infradead.org> References: <1350537079-16246-1-git-send-email-david@fromorbit.com> <20121023123044.GG7341@infradead.org> <20121023215313.GQ4291@dastard> <20121024114711.GB11262@shiny> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Chris Mason , Dave Chinner , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "xfs@oss.sgi.com" Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:55353 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935093Ab2JXPJy (ORCPT ); Wed, 24 Oct 2012 11:09:54 -0400 Content-Disposition: inline In-Reply-To: <20121024114711.GB11262@shiny> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 24, 2012 at 07:47:17AM -0400, Chris Mason wrote: > I'm all for it in the main fiemap call, it makes much more sense for the > users I think. How so? Current fiemap is a per-inode information, Daves new call is per-fs. Making one a flag of another is a gross user interface. In addition we're bound to get issue where filesystems fail to wire up fiemap to the tons of different iops just for this operation, or accidentally wire up "real" fiemap to things like special files or pipes. Btw, I'd like t orestate that I really love to see this functionality in the VFS, just not multiplexed over FIEMAP.