From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [RFC, PATCH 0/2] fiemap: filesystem free space mapping Date: Thu, 25 Oct 2012 06:15:15 +1100 Message-ID: <20121024191515.GU4291@dastard> References: <1350537079-16246-1-git-send-email-david@fromorbit.com> <20121023123044.GG7341@infradead.org> <20121023215313.GQ4291@dastard> <20121024114711.GB11262@shiny> <20121024150951.GA24318@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Mason , "linux-fsdevel@vger.kernel.org" , "xfs@oss.sgi.com" To: Christoph Hellwig Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:45838 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161129Ab2JXTPT (ORCPT ); Wed, 24 Oct 2012 15:15:19 -0400 Content-Disposition: inline In-Reply-To: <20121024150951.GA24318@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 24, 2012 at 11:09:51AM -0400, Christoph Hellwig wrote: > On Wed, Oct 24, 2012 at 07:47:17AM -0400, Chris Mason wrote: > > I'm all for it in the main fiemap call, it makes much more sense for the > > users I think. > > How so? Current fiemap is a per-inode information, Daves new call is > per-fs. Making one a flag of another is a gross user interface. In > addition we're bound to get issue where filesystems fail to wire up > fiemap to the tons of different iops just for this operation, or > accidentally wire up "real" fiemap to things like special files or > pipes. > > Btw, I'd like t orestate that I really love to see this functionality in > the VFS, just not multiplexed over FIEMAP. That's fine. I just wanted to clarify what you were asking. FIEMAPFS it is, then... Cheers, Dave. -- Dave Chinner david@fromorbit.com