From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aristeu Rozanski <aris@redhat.com>
Subject: Re: [PATCH] fs: xattr: rewrite simple_xattr_set()
Date: Thu, 25 Oct 2012 14:12:48 -0400
Message-ID: <20121025181248.GH14085@redhat.com>
References: <20121025152613.GF14085@redhat.com>
 <20121025173326.GH11442@htj.dyndns.org>
 <20121025175412.GG14085@redhat.com>
 <CAOS58YMJBNquaeP7rBzWu8vTWukAT3itH+qSt0cJxMmpTm0YEQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, Hugh Dickins <hughd@google.com>
To: Tejun Heo <tj@kernel.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAOS58YMJBNquaeP7rBzWu8vTWukAT3itH+qSt0cJxMmpTm0YEQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Oct 25, 2012 at 10:59:35AM -0700, Tejun Heo wrote:
> On Thu, Oct 25, 2012 at 10:54 AM, Aristeu Rozanski <aris@redhat.com> wrote:
> >> So, it returns 0 on success and 1 on failure, which in itself isn't a
> >> particularly good idea.
> >
> > you mean it should return -ENODATA instead?
> 
> Yeap, this is a bug, right?  We end up passing that 1 to the set_xattr caller.

yes, will resubmit

Thanks!

-- 
Aristeu