From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode Date: Mon, 29 Oct 2012 16:49:36 -0700 Message-ID: <20121029164936.2022db6c.akpm@linux-foundation.org> References: <1351389223-2628-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: hirofumi@mail.parknet.co.jp, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: <1351389223-2628-1-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon wrote: > From: Namjae Jeon > > fat_nfs_get_inode does not hold i_mutex of parent directory.So add > lock to fat_build_inode. Well.. why? Presumably this patch fixes some race. A good description of that race would be useful - partly because others may then be able to suggest alternative ways of fixing that bug. I'll merge these patches for some testing. I did merge these patches three weekes ago: fat-modify-nfs-mount-option.patch fat-exportfs-rebuild-inode-if-ilookup-fails.patch fat-exportfs-rebuild-inode-if-ilookup-fails-fix.patch fat-exportfs-rebuild-directory-inode-if-fat_dget-fails.patch documentation-update-nfs-option-in-filesystem-vfattxt.patch But I have no record of Bruce or Ogawa having reviewed/acked them?