From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: NeilBrown <neilb@suse.de>, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] bdi: Create a flag to indicate that a backing device needs stable page writes
Date: Tue, 30 Oct 2012 13:14:24 -0700 [thread overview]
Message-ID: <20121030201424.GD19559@blackbox.djwong.org> (raw)
In-Reply-To: <yq1a9v4884i.fsf@sermon.lab.mkp.net>
On Tue, Oct 30, 2012 at 08:19:41AM -0400, Martin K. Petersen wrote:
> >>>>> "Neil" == NeilBrown <neilb@suse.de> writes:
>
> Neil,
>
> >> Might be nice to make the sysfs knob tweakable. Also, don't forget to
> >> add a suitable blurb to Documentation/ABI/.
>
> Neil> It isn't at all clear to me that having the sysfs knob
> Neil> 'tweakable' is a good idea. From the md/raid5 perspective, I
> Neil> would want to know for certain whether the pages in a give bio
> Neil> are guaranteed not to change, or if they might. I could set the
> Neil> BDI_CAP_STABLE_WRITES and believe they will never change, or test
> Neil> the BDI_CAP_STABLE_WRITES and let that tell me if they might
> Neil> change or not. But if the bit can be changed at any moment, then
> Neil> it can never be trusted and so becomes worthless to me.
>
> I was mostly interested in being able to turn it on for devices that
> haven't explicitly done so. I agree that turning it off can be
> problematic.
I'm ok with having a tunable that can turn it on, but atm I can't really think
of a convincing reason to let people turn it /off/. If people yell loud enough
I'll add it, but I'd rather not have to distinguish between "on because user
set it on" vs "on because hw needs it".
It'd be nice if the presence BDI_CAP_STABLE_WRITES meant that all filesystems
would wait on page writes. Hrm, guess I'll see about adding that to the patch
set. Though ISTR that at least the vfat and ext2 maintainers weren't
interested the last time I asked.
--D
>
> --
> Martin K. Petersen Oracle Linux Engineering
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-30 20:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 10:19 semi-stable page writes Darrick J. Wong
2012-10-27 1:35 ` [RFC PATCH 1/2] bdi: Create a flag to indicate that a backing device needs stable " Darrick J. Wong
2012-10-29 18:13 ` Jan Kara
2012-10-29 18:30 ` Jan Kara
2012-10-29 23:48 ` NeilBrown
2012-10-30 0:10 ` Jan Kara
2012-10-30 0:34 ` NeilBrown
2012-10-30 13:38 ` Jan Kara
2012-10-30 21:49 ` NeilBrown
2012-10-30 4:10 ` Martin K. Petersen
2012-10-30 4:48 ` NeilBrown
2012-10-30 12:19 ` Martin K. Petersen
2012-10-30 20:14 ` Darrick J. Wong [this message]
2012-10-30 22:14 ` NeilBrown
2012-10-30 23:58 ` Boaz Harrosh
2012-10-31 8:56 ` Darrick J. Wong
2012-10-31 11:56 ` Jan Kara
2012-10-31 19:36 ` Darrick J. Wong
2012-10-31 23:12 ` Boaz Harrosh
2012-11-01 5:51 ` Darrick J. Wong
2012-11-01 6:25 ` Boaz Harrosh
2012-11-01 8:59 ` Jan Kara
2012-11-01 17:24 ` Boaz Harrosh
2012-11-01 22:42 ` Jan Kara
2012-10-30 22:40 ` Boaz Harrosh
2012-10-27 1:36 ` [RFC PATCH 2/2] mm: Gate stable page writes on the bdi flag Darrick J. Wong
2012-10-29 18:28 ` Jan Kara
2012-10-31 8:58 ` Darrick J. Wong
2012-10-29 22:01 ` semi-stable page writes Dave Chinner
2012-10-30 1:00 ` Theodore Ts'o
2012-10-30 23:30 ` Dave Chinner
2012-10-31 11:45 ` Jan Kara
2012-10-30 20:40 ` Darrick J. Wong
2012-10-30 23:43 ` Dave Chinner
2012-10-31 9:05 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030201424.GD19559@blackbox.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).