linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: BUG: enabling psacct breaks fsfreeze
Date: Thu, 1 Nov 2012 23:50:53 +0100	[thread overview]
Message-ID: <20121101225053.GB31937@quack.suse.cz> (raw)
In-Reply-To: <20121101142325.GD20752@pcnci.linuxbox.cz>

On Thu 01-11-12 15:23:25, Nikola Ciprich wrote:
> Nov  1 14:23:25 vmnci22 [ 1075.178123] SysRq : Show Blocked State
> Nov  1 14:23:25 vmnci22 [ 1075.180555]   task                        PC stack   pid father
> Nov  1 14:23:25 vmnci22 [ 1075.180592] fsfreeze      D 0000000000000000     0  4215   4195 0x00000000
> Nov  1 14:23:25 vmnci22 [ 1075.180599]  ffff8800090b9b28 0000000000000046 0000000000000000 ffffffff00000000
> Nov  1 14:23:25 vmnci22 [ 1075.180606]  0000000000013780 ffff8800090b9fd8 ffff88000f716170 ffff88000f715e80
> Nov  1 14:23:25 vmnci22 [ 1075.180612]  ffff88000f715dc0 ffffffff81566080 ffff88000f716170 000000010002f405
> Nov  1 14:23:25 vmnci22 [ 1075.180619] Call Trace:
> Nov  1 14:23:25 vmnci22 [ 1075.180693]  [<ffffffff810e2dbb>] __generic_file_aio_write+0xbb/0x420
> Nov  1 14:23:25 vmnci22 [ 1075.180729]  [<ffffffff81079290>] ? autoremove_wake_function+0x0/0x40
> Nov  1 14:23:25 vmnci22 [ 1075.180736]  [<ffffffff810e317f>] generic_file_aio_write+0x5f/0xc0
  Thanks. So the system isn't really deadlocked. It's just that fsfreeze
command hangs, isn't it? OK, I understand that it's kind of incovenient
situation because every command will hang like this when the filesystem is
frozen.

Now I only have to come up with a way to improve this... It isn't quite
simple - to properly protect against freezing be have to communicate down
into generic_file_aio_write() that we want to bail out if filesystem is
frozen instead of waiting.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2012-11-01 22:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  9:43 BUG: enabling psacct breaks fsfreeze Nikola Ciprich
2012-10-31 12:15 ` Jan Kara
2012-10-31 12:46   ` Nikola Ciprich
2012-11-01  9:37     ` Jan Kara
2012-11-01 11:19       ` Jan Kara
2012-11-01 14:23         ` Nikola Ciprich
2012-11-01 22:50           ` Jan Kara [this message]
2012-11-02  9:50             ` Marco Stornelli
2012-11-02 10:40               ` Nikola Ciprich
2012-11-03  8:22                 ` Marco Stornelli
2012-11-07 18:51             ` Jan Kara
2012-11-07 21:21               ` Nikola Ciprich
2012-11-07 22:32                 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121101225053.GB31937@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikola.ciprich@linuxbox.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).