From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: avoid crash on failed block map free
Date: Sat, 3 Nov 2012 16:27:01 +0000 [thread overview]
Message-ID: <20121103162701.090743b1@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <EBAFDECD-6E61-4FD7-A49F-139986D71420@dubeyko.com>
> Your patch is good. But what about returning an error code (for example, -EIO)? Unfortunately, as I can see, the code that call hfsplus_block_free() doesn't analyze return code. I think that it is not good.
Actually handling the error nicely is a major rework of the file system.
If you want to do that send patches but you'll need to fix up another ton
of places.
The patch fixes the crash to the same level of not crashing the rest of
that file system has.
Alan
next prev parent reply other threads:[~2012-11-03 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:23 [PATCH] hfsplus: avoid crash on failed block map free Alan Cox
2012-11-03 11:19 ` Vyacheslav Dubeyko
2012-11-03 16:27 ` Alan Cox [this message]
2012-11-03 17:44 ` Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121103162701.090743b1@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).