From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/2 v2] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs Date: Mon, 12 Nov 2012 16:42:43 +1100 Message-ID: <20121112054243.GQ24575@dastard> References: <1352378498-30625-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, dchinner@redhat.com To: Jan Kara Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:14257 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856Ab2KLFmq (ORCPT ); Mon, 12 Nov 2012 00:42:46 -0500 Content-Disposition: inline In-Reply-To: <1352378498-30625-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 08, 2012 at 01:41:37PM +0100, Jan Kara wrote: > When user asks for O_NONBLOCK behavior for a file descriptor, return > EAGAIN instead of blocking on a frozen filesystem. > > Signed-off-by: Jan Kara > --- > fs/btrfs/file.c | 3 ++- > fs/cifs/file.c | 3 ++- > fs/fuse/file.c | 3 ++- > fs/ntfs/file.c | 3 ++- > fs/ocfs2/file.c | 3 ++- > fs/xfs/xfs_file.c | 3 ++- > include/linux/fs.h | 10 ++++++++++ > mm/filemap.c | 3 ++- > 8 files changed, 24 insertions(+), 7 deletions(-) Looks good, though you missed generic_file_splice_write(). Shouldn't this also return EAGAIN? Cheers, Dave. -- Dave Chinner david@fromorbit.com