From: Jan Kara <jack@suse.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, dchinner@redhat.com
Subject: Re: [PATCH 1/2 v2] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs
Date: Mon, 12 Nov 2012 11:45:31 +0100 [thread overview]
Message-ID: <20121112104531.GA23297@quack.suse.cz> (raw)
In-Reply-To: <20121112054243.GQ24575@dastard>
On Mon 12-11-12 16:42:43, Dave Chinner wrote:
> On Thu, Nov 08, 2012 at 01:41:37PM +0100, Jan Kara wrote:
> > When user asks for O_NONBLOCK behavior for a file descriptor, return
> > EAGAIN instead of blocking on a frozen filesystem.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > fs/btrfs/file.c | 3 ++-
> > fs/cifs/file.c | 3 ++-
> > fs/fuse/file.c | 3 ++-
> > fs/ntfs/file.c | 3 ++-
> > fs/ocfs2/file.c | 3 ++-
> > fs/xfs/xfs_file.c | 3 ++-
> > include/linux/fs.h | 10 ++++++++++
> > mm/filemap.c | 3 ++-
> > 8 files changed, 24 insertions(+), 7 deletions(-)
>
> Looks good, though you missed generic_file_splice_write(). Shouldn't
> this also return EAGAIN?
Yes, it should. Thanks for spotting this. I've also noticed ocfs2 misses
freeze protection in splice_write at all. I'll fix that in a separate
patch and send v3.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2012-11-12 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 12:41 [PATCH 1/2 v2] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs Jan Kara
2012-11-08 12:41 ` [PATCH 2/2 v2] fs: Fix hang with BSD accounting on frozen filesystem Jan Kara
2012-11-12 5:43 ` Dave Chinner
2012-11-10 9:23 ` [PATCH 1/2 v2] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs Marco Stornelli
2012-11-12 5:42 ` Dave Chinner
2012-11-12 10:45 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112104531.GA23297@quack.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).