From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] hfsplus: avoid crash on failed block map free Date: Wed, 14 Nov 2012 12:24:48 +0100 Message-ID: <20121114112448.GA27431@lst.de> References: <1352799065.2443.3.camel@slavad-ubuntu> <20121113143444.f8d4bbc3.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vyacheslav Dubeyko , Alan Cox , linux-fsdevel@vger.kernel.org, Christoph Hellwig To: Andrew Morton Return-path: Received: from verein.lst.de ([213.95.11.211]:43154 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422635Ab2KNLf0 (ORCPT ); Wed, 14 Nov 2012 06:35:26 -0500 Content-Disposition: inline In-Reply-To: <20121113143444.f8d4bbc3.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 13, 2012 at 02:34:44PM -0800, Andrew Morton wrote: > It looks better than what we currently have! > > The code is missing a flush_dcache_page()? We should have one in there > after the CPU has modified userspace-mappable page contents. > > > btw, I still have question marks over your earlier patches: > > hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch > hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch > hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch > hfsplus-add-support-of-manipulation-by-attributes-file.patch > hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch > hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch > > Christoph sounded unhappy, but the review discussion petered out? It really just needs the xattr namespace fixed. JFS is a good model for how to expose the legacy OS/2 attributes that are lacking a namespace prefix.