From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Jeff Liu <jeff.liu@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Andreas Dilger <aedilger@gmail.com>,
John Sobecki <john.sobecki@oracle.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
Alan Cox <alan@linux.intel.com>, "arnd@arndb.de" <arnd@arndb.de>,
James Morris <james.l.morris@oracle.com>,
"Ted Ts'o" <tytso@mit.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
jakub@redhat.com, drepper@redhat.com,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RESEND PATCH V3] binfmt_elf.c: use get_random_int() to fix entropy depleting
Date: Wed, 14 Nov 2012 13:09:09 -0800 [thread overview]
Message-ID: <20121114130909.2dcc5b75.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jLC9aj3KewbFb2tHoisjvqj4KkMwpA6KiZ7y8k15WWOwA@mail.gmail.com>
On Tue, 6 Nov 2012 23:13:54 -0800
Kees Cook <keescook@chromium.org> wrote:
> On Tue, Nov 6, 2012 at 11:02 PM, Jeff Liu <jeff.liu@oracle.com> wrote:
> > On 11/07/2012 02:21 PM, Kees Cook wrote:
> >> I still want to hear at least from Ted about this changes -- we would
> >> be potentially increasing the predictability of these bytes...
> >
> > We would not increasing that if this routine would be used for AT_RANDOM
> > only(and if the array keeping aligned to 4 bytes).
> > Otherwise, it would be, so let's waiting for further feedbacks.
>
> get_random_int() comes from a different pool than get_random_bytes(),
> IIUC. I'd like to hear some convincing reasoning as to why this change
> doesn't compromise predictability. :)
But the original "ELF: implement AT_RANDOM for glibc PRNG seeding"
compromised predictability. That's the whole point of this patch.
What was so important about that patch that justified gobbling down so
much of the system's entropy accumulation?
next prev parent reply other threads:[~2012-11-14 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 5:27 [PATCH V3] binfmt_elf.c: Introduce a wrapper of get_random_int() to fix entropy depleting Jeff Liu
2012-11-07 5:52 ` Jeff Liu
2012-11-07 6:11 ` [RESEND PATCH V3] binfmt_elf.c: use " Jeff Liu
2012-11-07 6:21 ` Kees Cook
2012-11-07 7:02 ` Jeff Liu
2012-11-07 7:13 ` Kees Cook
2012-11-14 21:09 ` Andrew Morton [this message]
2012-11-14 21:14 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114130909.2dcc5b75.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aedilger@gmail.com \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=drepper@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jakub@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=jeff.liu@oracle.com \
--cc=john.sobecki@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).