From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs, freeze: use ACCESS_ONCE() to guard access to ->mnt_flags Date: Fri, 16 Nov 2012 13:25:39 +0000 Message-ID: <20121116132539.GV2616@ZenIV.linux.org.uk> References: <50A60626.4080200@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Fsdevel , Jan Kara To: Miao Xie Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:33168 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624Ab2KPNZl (ORCPT ); Fri, 16 Nov 2012 08:25:41 -0500 Content-Disposition: inline In-Reply-To: <50A60626.4080200@cn.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 16, 2012 at 05:23:50PM +0800, Miao Xie wrote: > The compiler may optimize the while loop and make the check just be done once, > so we should use ACCESS_ONCE() to guard access to ->mnt_flags Applied.