From: Christoph Hellwig <hch@infradead.org>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, yan@linux.vnet.ibm.com,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2
Date: Tue, 20 Nov 2012 05:14:53 -0500 [thread overview]
Message-ID: <20121120101452.GA692@infradead.org> (raw)
In-Reply-To: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com>
On Tue, Nov 20, 2012 at 05:29:41PM +0800, Zheng Liu wrote:
> Hi all,
>
> This patch series tries to remove a sanity check in fallocate from specific
> filesystems because vfs has already checked it.
>
> I am not very familiar with why we need to do this duplicated check. Please let
> me know if I miss something.
Each filesystem driver checks to see if a flag that it doesn't support
gets passed down. This was done with the intention that we can add new
flags to the VFS without having to update every filesystem.
next prev parent reply other threads:[~2012-11-20 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:29 [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2 Zheng Liu
2012-11-20 9:29 ` [PATCH 1/4][RFC] ext4: remove duplicated check from ext4_fallocate Zheng Liu
2012-11-20 9:29 ` [PATCH 2/4][RFC] xfs: remove duplicated check from xfs_file_fallocate Zheng Liu
2012-11-20 9:29 ` [PATCH 3/4][RFC] btrfs: remove duplicated check from btrfs_fallocate Zheng Liu
2012-11-20 9:29 ` [PATCH 4/4][RFC] ocfs2: remove duplicated check from ocfs2_fallocate Zheng Liu
2012-11-20 10:14 ` Christoph Hellwig [this message]
2012-11-20 10:46 ` [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2 Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120101452.GA692@infradead.org \
--to=hch@infradead.org \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
--cc=yan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).