From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [Bug 50981] generic_file_aio_read ?: No locking means DATA CORRUPTION read and write on same 4096 page range Date: Mon, 26 Nov 2012 20:32:54 -0500 Message-ID: <20121127013254.GA25222@thunk.org> References: <20121126163328.ACEB011FE9C@bugzilla.kernel.org> <20121126164555.GL31891@thunk.org> <20121126201308.GA21050@infradead.org> <20121126214937.GA21590@thunk.org> <20121126220908.GA20733@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hugh Dickins , Andrew Morton , Al Viro , bugzilla-daemon@bugzilla.kernel.org, meetmehiro@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20121126220908.GA20733@infradead.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 26, 2012 at 05:09:08PM -0500, Christoph Hellwig wrote: > On Mon, Nov 26, 2012 at 04:49:37PM -0500, Theodore Ts'o wrote: > > Christoph, can you give some kind of estimate for the overhead that > > adding this locking in XFS actually costs in practice? > > I don't know any real life measurements, but in terms of implementation > the over head is: > > a) taking a the rw_semaphore in shared mode for every buffered read > b) taking the slightly slower exclusive rw_semaphore for buffered writes > instead of the plain mutex > > On the other hand it significantly simplifies the locking for direct > I/O and allows parallel direct I/O writers. I should probably just look at the XFS code, but.... if you're taking an exclusve lock for buffered writes, won't this impact the performance of buffered writes happening in parallel on different CPU's? - Ted -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org