From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise) Date: Thu, 29 Nov 2012 13:44:46 +1100 Message-ID: <20121129024446.GY6434@dastard> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Theodore Ts'o , Zheng Liu , Jeff liu , Jim Meyering , Paul Eggert , Christoph Hellwig , Josef Bacik , Andi Kleen , Andreas Dilger , Marco Stornelli , Chris Mason , Sunil Mushran , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org To: Hugh Dickins Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 28, 2012 at 05:22:03PM -0800, Hugh Dickins wrote: > Revert 3.5's f21f8062201f ("tmpfs: revert SEEK_DATA and SEEK_HOLE") > to reinstate 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"), > with the intervening additional arg to generic_file_llseek_size(). > > In 3.8, ext4 is expected to join btrfs, ocfs2 and xfs with proper > SEEK_DATA and SEEK_HOLE support; and a good case has now been made > for it on tmpfs, so let's join the party. > > It's quite easy for tmpfs to scan the radix_tree to support llseek's new > SEEK_DATA and SEEK_HOLE options: so add them while the minutiae are still > on my mind (in particular, the !PageUptodate-ness of pages fallocated but > still unwritten). > > [akpm@linux-foundation.org: fix warning with CONFIG_TMPFS=n] > Signed-off-by: Hugh Dickins > --- Does it pass the seek hole/data tests (285, 286) in xfstests? Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org