From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Zheng Liu <wenqing.lz@taobao.com>, Jeff liu <jeff.liu@oracle.com>,
Jim Meyering <jim@meyering.net>, Paul Eggert <eggert@cs.ucla.edu>,
Christoph Hellwig <hch@infradead.org>,
Josef Bacik <josef@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Andreas Dilger <adilger@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Marco Stornelli <marco.stornelli@gmail.com>,
Chris Mason <chris.mason@fusionio.com>,
Sunil Mushran <sunil.mushran@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)
Date: Thu, 29 Nov 2012 16:18:21 -0800 [thread overview]
Message-ID: <20121129161821.8103962c.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1211291522550.3226@eggly.anvils>
On Thu, 29 Nov 2012 15:29:15 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:
> On Thu, 29 Nov 2012, Andrew Morton wrote:
> > On Wed, 28 Nov 2012 17:22:03 -0800 (PST)
> > Hugh Dickins <hughd@google.com> wrote:
> >
> > > +/*
> > > + * llseek SEEK_DATA or SEEK_HOLE through the radix_tree.
> > > + */
> > > +static pgoff_t shmem_seek_hole_data(struct address_space *mapping,
> > > + pgoff_t index, pgoff_t end, int origin)
> >
> > So I was starting at this wondering what on earth "origin" is and why
> > it has the fishy-in-this-context type "int".
> >
> > There is a pretty well established convention that the lseek seek mode
> > is called "whence".
> >
> > The below gets most of it. Too anal?
>
> No, not too anal: I'm all in favour of "whence", which is indeed
> the name of that lseek argument - since mediaeval times I believe.
Alas, the rest of us don't have personal memories from those days.
> It's good to have words like that in the kernel source: while you're
> in the mood, please see if you can find good homes for "whither" and
> "thrice" and "widdershins".
We use "thrice" quite a lot. And "whither" once coz alfa peeps cnat spel.
No widdershins yet.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-11-30 0:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 1:22 [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise) Hugh Dickins
2012-11-29 1:29 ` Jaegeuk Hanse
2012-11-29 2:02 ` Hugh Dickins
2012-11-29 4:15 ` Jim Meyering
2012-11-29 4:42 ` Jeff Liu
2012-11-29 6:53 ` Jim Meyering
2012-11-29 7:27 ` Jeff Liu
2012-11-29 19:52 ` Dave Chinner
2012-11-29 20:17 ` Jim Meyering
2012-11-29 2:44 ` Dave Chinner
2012-11-29 4:22 ` Hugh Dickins
2012-11-29 22:59 ` Andrew Morton
2012-11-29 23:29 ` Hugh Dickins
2012-11-30 0:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129161821.8103962c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger@dilger.ca \
--cc=andi@firstfloor.org \
--cc=chris.mason@fusionio.com \
--cc=david@fromorbit.com \
--cc=eggert@cs.ucla.edu \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jeff.liu@oracle.com \
--cc=jim@meyering.net \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marco.stornelli@gmail.com \
--cc=sunil.mushran@oracle.com \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).