From: Al Viro <viro@ZenIV.linux.org.uk>
To: Abhijit Pawar <abhi.c.pawar@gmail.com>,
linux-fsdevel@vger.kernel.org,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization
Date: Fri, 30 Nov 2012 04:05:56 +0000 [thread overview]
Message-ID: <20121130040556.GD4939@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121026131441.GA22256@andromeda.usersys.redhat.com>
On Fri, Oct 26, 2012 at 11:14:41AM -0200, Carlos Maiolino wrote:
> Hi,
>
> On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote:
> > Hi,
> > set_anon_super is called by many filesystems. Some call directly and
> > some call through the wrapper. Many of them in the wrapper's call to
> > this function are passing the second argument to this function which
> > is not used anywhere.
> >
> > This patch replaces the second variable with NULL.
> >
>
> If the variable isn't used anymore, why don't just get rid of it, instead of
> call the function passing a NULL pointer on it?
Because we want it to be a valid sget() callback. I doubt that this
optimization is worth doing, though - might even micro-pessimize the things
on architectures where all arguments are passed in registers.
next prev parent reply other threads:[~2012-11-30 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+kxV1F5VxBGawhkV=02LcgHNWiKF-H_k6N-d1TEYNeFAScezg@mail.gmail.com>
2012-10-25 11:38 ` [RESEND PATCH] fs/super.c set_anon_super calling optimization Abhijit Pawar
2012-10-26 13:14 ` Carlos Maiolino
2012-10-26 13:40 ` Abhijit Pawar
2012-11-30 4:05 ` Al Viro [this message]
2012-11-30 5:40 ` Abhijit Pawar
2012-11-30 6:04 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130040556.GD4939@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=abhi.c.pawar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).