From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] Do a proper locking for mmap and block size change Date: Fri, 30 Nov 2012 18:09:00 -0500 Message-ID: <20121130230900.GA12674@infradead.org> References: <20121129191503.GB3490@shiny> <20121129194840.GC3490@shiny> <20121129212931.GD3490@shiny> <20121130024910.GF6434@dastard> <20121130163601.GA32238@infradead.org> <20121130224041.GD12955@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Linus Torvalds , Chris Mason , Chris Mason , Mikulas Patocka , Al Viro , Jens Axboe , Jeff Chua , Lai Jiangshan , Jan Kara , lkml , linux-fsdevel To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <20121130224041.GD12955@dastard> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Dec 01, 2012 at 09:40:41AM +1100, Dave Chinner wrote: > So it was based on this interface? Based on that. I had dropped the inode operation as it's not really a generic operation but a callback for either the buffered I/O code or direct I/O and should be treated as such. I've also split the single multiplexer function into individual ones, but the underlying data structure and fundamental operations are the same. > (I went looking for this code on google a couple of days ago so I > could point at it and say "we should be using an iomap structure, > not buffer heads", but it looks like I never posted it to fsdevel or > the xfs lists...) Your version defintively was up on your kernel.org XFS tree, that's what I started from. I'll have a long plane right tonight, let's see if I can get the direct I/O version updated.