From: Mel Gorman <mgorman@suse.de>
To: Lin Feng <linfeng@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
viro@zeniv.linux.org.uk, bcrl@kvack.org,
kamezawa.hiroyu@jp.fujitsu.com, mhocko@suse.cz, hughd@google.com,
cl@linux.com, minchan@kernel.org, isimatu.yasuaki@jp.fujitsu.com,
laijs@cn.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined
Date: Mon, 3 Dec 2012 11:37:04 +0000 [thread overview]
Message-ID: <20121203113704.GK8218@suse.de> (raw)
In-Reply-To: <50BC13EB.1050009@cn.fujitsu.com>
On Mon, Dec 03, 2012 at 10:52:27AM +0800, Lin Feng wrote:
>
>
> On 11/30/2012 07:00 PM, Mel Gorman wrote:
> >>
> >> Well, that's a fairly low-level implementation detail. A more typical
> >> approach would be to add a new get_user_pages_non_movable() or such.
> >> That would probably have the same signature as get_user_pages(), with
> >> one additional argument. Then get_user_pages() becomes a one-line
> >> wrapper which passes in a particular value of that argument.
> >>
> >
> > That is going in the direction that all pinned pages become MIGRATE_UNMOVABLE
> > allocations. That will impact THP availability by increasing the number
> > of MIGRATE_UNMOVABLE blocks that exist and it would hit every user --
> > not just those that care about ZONE_MOVABLE.
> >
> > I'm likely to NAK such a patch if it's only about node hot-remove because
> > it's much more of a corner case than wanting to use THP.
> >
> > I would prefer if get_user_pages() checked if the page it was about to
> > pin was in ZONE_MOVABLE and if so, migrate it at that point before it's
> > pinned. It'll be expensive but will guarantee ZONE_MOVABLE availability
> > if that's what they want. The CMA people might also want to take
> > advantage of this if the page happened to be in the MIGRATE_CMA
> > pageblock.
> >
> hi Mel,
>
> Thanks for your suggestion.
> My initial idea is also to restrict the impact as little as possible so
> migrate such pages as we need.
> But even to such "going to pin pages", most of them are going to be released
> soon, so deal with them all in the same way is really *expensive*.
>
Then you need to somehow distinguish between short-lived pins and
long-lived pins and only migrate the long-lived pins. I didn't research
how this could be implemented
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2012-12-03 11:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 6:54 [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined Lin Feng
2012-11-29 23:39 ` Andrew Morton
2012-11-30 0:04 ` Zach Brown
2012-11-30 3:39 ` Lin Feng
2012-11-30 3:42 ` Lin Feng
2012-11-30 5:57 ` Andrew Morton
2012-11-30 7:01 ` Lin Feng
2012-11-30 7:55 ` Andrew Morton
2012-11-30 10:29 ` Lin Feng
2012-11-30 10:47 ` Andrew Morton
2012-12-03 3:00 ` Lin Feng
2012-11-30 11:00 ` Mel Gorman
2012-12-03 2:52 ` Lin Feng
2012-12-03 11:37 ` Mel Gorman [this message]
2012-11-30 7:13 ` Kamezawa Hiroyuki
2012-11-30 8:00 ` Andrew Morton
2012-11-30 10:57 ` Mel Gorman
2012-11-30 15:24 ` Domenico Andreoli
2012-12-03 2:05 ` Lin Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203113704.GK8218@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).