From: Theodore Ts'o <tytso@mit.edu>
To: qixuan wu <wuqixuan@gmail.com>
Cc: Tao Ma <tm@tao.ma>, Li Zefan <lizefan@huawei.com>,
Eric Sandeen <sandeen@redhat.com>,
Yafang Shao <laoar.shao@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
wuqixuan@huawei.com
Subject: Re: help about ext3 read-only issue on ext3(2.6.16.30)
Date: Tue, 4 Dec 2012 15:45:08 -0500 [thread overview]
Message-ID: <20121204204508.GG7790@thunk.org> (raw)
In-Reply-To: <CAEjEV8D7G3xaT_Y4KdH7eVA-bdexjEE5iKPFRQ=Psgfmmoe-+g@mail.gmail.com>
On Wed, Dec 05, 2012 at 12:16:50AM +0800, qixuan wu wrote:
>
> Is there the possibility: one thread(A) is read_dir(directly read
> from buffer head), and another thread(B) is creating item, and fill
> this buffer header at the same time. During create item, first modify
> the last item's rec_len(let it point to next item which initially is
> zero), then fill this added new item.
This should be handled by the VFS, which uses i_mutex to protect
directories before calling the filesystem-specific lookup, rename,
readdir, etc functions.
So absent some bug where we are missing taking i_mutex (a quick check
didn't show any obvious missing paths, although I didn't do an
exhaustive code audit), we should be OK.... if we had a bug here, I
would have expected that one of the fs stress tests that we run would
have shown them up pretty quickly.
Regards,
- Ted
next prev parent reply other threads:[~2012-12-04 20:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 14:22 help about ext3 read-only issue on ext3(2.6.16.30) Yafang Shao
2012-12-03 17:59 ` Eric Sandeen
2012-12-04 13:54 ` Li Zefan
2012-12-04 15:09 ` Theodore Ts'o
2012-12-05 10:43 ` Li Zefan
2012-12-05 14:26 ` Tao Ma
2012-12-05 15:51 ` qixuan wu
2012-12-06 1:13 ` Li Zefan
2012-12-06 12:37 ` Jan Kara
2012-12-06 16:21 ` qixuan wu
2012-12-06 17:09 ` Jan Kara
2012-12-07 10:03 ` Li Zefan
2012-12-11 8:01 ` Li Zefan
2012-12-12 10:04 ` Jan Kara
2012-12-12 11:31 ` Li Zefan
2012-12-14 3:32 ` Peng, Tao
2012-12-17 10:51 ` Li Zefan
2012-12-20 11:32 ` Jan Kara
2013-02-12 12:19 ` Jan Kara
2012-12-04 15:29 ` Tao Ma
2012-12-04 16:11 ` Bernd Schubert
2012-12-04 20:20 ` Theodore Ts'o
2012-12-04 16:16 ` qixuan wu
2012-12-04 20:45 ` Theodore Ts'o [this message]
2012-12-05 13:58 ` Tao Ma
2012-12-05 15:05 ` Theodore Ts'o
2012-12-06 1:54 ` Tao Ma
2012-12-06 15:48 ` qixuan wu
2012-12-05 15:46 ` qixuan wu
2012-12-06 2:58 ` Yongqiang Yang
2012-12-06 16:26 ` qixuan wu
2012-12-07 1:49 ` Yongqiang Yang
2012-12-05 10:46 ` Li Zefan
2012-12-05 14:02 ` Tao Ma
2012-12-06 1:17 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204204508.GG7790@thunk.org \
--to=tytso@mit.edu \
--cc=laoar.shao@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=sandeen@redhat.com \
--cc=tm@tao.ma \
--cc=wuqixuan@gmail.com \
--cc=wuqixuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).