From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] vfs: clear to the end of the buffer on reads
Date: Wed, 5 Dec 2012 19:59:21 +0300
Message-ID: <20121205165921.GM6568@mwanda>
References: <20121205124403.GA31930@elgon.mountain>
 <CA+55aFyCuepCzYq4zsLJyMO0yKzb=jD0-zv9zG6RyFYABOGe5w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	Romain Francoise <romain@orebokech.com>,
	Meelis Roos <mroos@linux.ee>, Tony Luck <tony.luck@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from aserp1040.oracle.com ([141.146.126.69]:28074 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751766Ab2LEQ7j (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 5 Dec 2012 11:59:39 -0500
Content-Disposition: inline
In-Reply-To: <CA+55aFyCuepCzYq4zsLJyMO0yKzb=jD0-zv9zG6RyFYABOGe5w@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote:
> On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > READ is zero so this test is always false.  (rw == READ) was intended.
> 
> Actually, that really *is* a bitmask, but yeah, the test is wrong.
> 
> The correct test is
> 
>   ((rw & RW_MASK) == READ)
> 

Ah.  Of course.  I'll send a v2.

regards,
dan carpenter