From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI Date: Fri, 7 Dec 2012 16:43:25 -0500 Message-ID: <20121207214325.GB25713@shiny> References: <201212051148.28039.Martin@lichtvoll.de> <20121206120532.GA14100@infradead.org> <20121207011628.GB16373@gmail.com> <50C22923.90102@redhat.com> <20121207190306.GB14972@shiny> <20121207204325.GC29435@thunk.org> <20121207210932.GA25713@shiny> <20121207212743.GE29435@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Chris Mason , Linus Torvalds , Ric Wheeler , Ingo Molnar , Christoph Hellwig , Martin Steigerwald , Linux Kernel Mailing List , Dave Chinner , linux-fsdevel To: Theodore Ts'o Return-path: Content-Disposition: inline In-Reply-To: <20121207212743.GE29435@thunk.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Dec 07, 2012 at 02:27:43PM -0700, Theodore Ts'o wrote: > On Fri, Dec 07, 2012 at 04:09:32PM -0500, Chris Mason wrote: > > Persistent trim is what I had in mind, but there are other ideas that do > > imply a change in behavior as well. Can we safely assume this feature > > won't matter on spinning media? New features like persistent > > trim do make it much easier to solve securely, and using a bit for it > > means we can toss back an error to the app if the underlying storage > > isn't safe. > > We originally implemented no hide stale for spinning media. Some > folks have claimed that for XFS their superior technology means that > no hide stale doesn't buy them anything for HDD's. I'm not entirely > sure I buy this, since if you need to update metadata, it means at > least one extra seek for each random write into 4k preallocated space, > and 7200 RPM disks only have about 200 seeks per second. True, 7200 RPM disks are slow, but even allowing them to expose stale data just makes them a little less slow. I know it's against the rules to pretend that disks don't matter. But really, once you're doing random IO into a spindle you've given up on performance anyway. -chris