From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH 1/2] [PATCH 1/2] direct-io: implement generic deferred AIO completions
Date: Sat, 8 Dec 2012 07:02:03 -0500 [thread overview]
Message-ID: <20121208120203.GB8442@infradead.org> (raw)
In-Reply-To: <20121206190537.GD21029@quack.suse.cz>
On Thu, Dec 06, 2012 at 08:05:37PM +0100, Jan Kara wrote:
> I like this, but this patch already breaks ext4, doesn't it?
> ^^^ Here ext4 offloads IO completion to a worker thread. So you now
> complete AIO / DIO before ext4_end_io() runs which is a bug (ext4_end_io()
> is responsible for example for calling end_page_writeback()). I'll modify
> these patches to work for ext4 tomorrow I hope...
You're right, patch 2 actively deadlocks ext4 under xfstests, but the
first one already breaks semantics. So any rework of the ext4 unwritten
extent handling really should go before these two patches.
next prev parent reply other threads:[~2012-12-08 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 7:55 [PATCH 0/2] handle O_(D)SYNC for AIO Christoph Hellwig
2012-11-23 7:55 ` [PATCH 1/2] [PATCH 1/2] direct-io: implement generic deferred AIO completions Christoph Hellwig
2012-11-27 16:17 ` Jeff Moyer
2012-12-06 19:05 ` Jan Kara
2012-12-08 12:02 ` Christoph Hellwig [this message]
2012-12-20 11:15 ` Jan Kara
2012-11-23 7:55 ` [PATCH 2/2] [PATCH 2/2] direct-io: handle handle O_(D)SYNC AIO Christoph Hellwig
2012-11-27 16:19 ` Jeff Moyer
2012-11-28 0:26 ` Darrick J. Wong
2012-11-28 0:30 ` Christoph Hellwig
2012-11-28 8:02 ` [RFC PATCH] ext4: Convert unwritten extents during end_io processing Darrick J. Wong
2012-11-28 14:34 ` Christoph Hellwig
2012-11-29 19:47 ` Darrick J. Wong
2012-12-05 13:08 ` [PATCH 2/2] [PATCH 2/2] direct-io: handle handle O_(D)SYNC AIO Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121208120203.GB8442@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).