From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: Are there u32 atomic bitops? (or dealing w/ i_flags) Date: Tue, 18 Dec 2012 01:57:05 +0000 Message-ID: <20121218015705.GH4939@ZenIV.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Linux FS Devel To: Andy Lutomirski Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Dec 17, 2012 at 05:10:21PM -0800, Andy Lutomirski wrote: > I want to change inode->i_flags access to be atomic -- there are some > locking oddities right now, I think, and I want to use a new inode > flag to signal mtime updates from page_mkwrite. The problem is that > i_flags is an unsigned int, and making it an unsigned long seems like > a waste, but there aren't any u32 atomic bitops. ... and atomic accesses cost more. A lot more on some architectures. FWIW, atomic_t *is* 32bit on 32bit architectures, which still doesn't make it a good idea.