From: Andrew Morton <akpm@linux-foundation.org>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] hfsplus: avoid crash on failed block map free
Date: Tue, 18 Dec 2012 14:47:55 -0800 [thread overview]
Message-ID: <20121218144755.475462ee.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352897453.2149.14.camel@slavad-ubuntu>
On Wed, 14 Nov 2012 16:50:53 +0400
Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> On Tue, 2012-11-13 at 14:34 -0800, Andrew Morton wrote:
>
> [snip]
> >
> > The code is missing a flush_dcache_page()? We should have one in there
> > after the CPU has modified userspace-mappable page contents.
> >
>
> Yes, I think your comment is precious. But I feel a necessity to analyze
> hfsplus driver code more deeply for proper fix of this issue. An
> userspace-mappable page content is the main use-case for such fix. But
> it exists the multi CPUs use-case. So, I need to think about correctness
> of hfsplus driver for such use-case also, I think.
>
> >
> > btw, I still have question marks over your earlier patches:
> >
> > hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch
> > hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch
> > hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch
> > hfsplus-add-support-of-manipulation-by-attributes-file.patch
> > hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch
> > hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch
> >
> > Christoph sounded unhappy, but the review discussion petered out?
> >
>
> So, as you can see the discussion revives again. :-) And I need to
> familiarize with implementation of xattrs in JFS before to answer again.
> I had objection that we need to remember about using HFS+ volumes as
> under Linux as under Mac OS X. Maybe, JFS implementation of xattrs to
> change my vision.
I'm still unclear where we stand with these patches. Which if any of
these should I merge?
Thanks.
hfsplus-avoid-crash-on-failed-block-map-free.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-avoid-crash-on-failed-block-map-free.patch
hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes.patch
hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch
hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch
hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch
hfsplus-add-support-of-manipulation-by-attributes-file.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-support-of-manipulation-by-attributes-file.patch
hfsplus-rework-processing-errors-in-hfsplus_free_extents.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-processing-errors-in-hfsplus_free_extents.patch
hfsplus-rework-processing-of-hfs_btree_write-returned-error.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-processing-of-hfs_btree_write-returned-error.patch
hfsplus-add-error-message-for-the-case-of-failure-of-sync-fs-in-delayed_sync_fs-method.patch
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-error-message-for-the-case-of-failure-of-sync-fs-in-delayed_sync_fs-method.patch
next prev parent reply other threads:[~2012-12-18 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 9:31 [PATCH v2] hfsplus: avoid crash on failed block map free Vyacheslav Dubeyko
2012-11-13 22:34 ` Andrew Morton
2012-11-14 11:24 ` Christoph Hellwig
2012-11-15 7:07 ` Vyacheslav Dubeyko
2012-11-15 9:17 ` Christoph Hellwig
2012-11-15 9:31 ` Vyacheslav Dubeyko
2012-11-14 12:50 ` Vyacheslav Dubeyko
2012-12-18 22:47 ` Andrew Morton [this message]
2012-12-19 6:26 ` Vyacheslav Dubeyko
2012-12-19 6:29 ` Andrew Morton
2012-12-19 6:42 ` Vyacheslav Dubeyko
2012-12-19 14:09 ` Christoph Hellwig
2012-12-19 14:15 ` Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218144755.475462ee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).