From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [RFC PATCH 4/4] ext4: Fix an incorrect comment about i_mutex Date: Fri, 21 Dec 2012 00:42:49 +0100 Message-ID: <20121220234249.GA13474@quack.suse.cz> References: <30dd429015418a31f6412fd1106a2df12d2922dd.1356043686.git.luto@amacapital.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Linux FS Devel , Dave Chinner , Al Viro , Jan Kara To: Andy Lutomirski Return-path: Received: from cantor2.suse.de ([195.135.220.15]:33156 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555Ab2LTXmv (ORCPT ); Thu, 20 Dec 2012 18:42:51 -0500 Content-Disposition: inline In-Reply-To: <30dd429015418a31f6412fd1106a2df12d2922dd.1356043686.git.luto@amacapital.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 20-12-12 15:10:12, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski The patch looks good. You can add: Reviewed-by: Jan Kara BTW: The right person for this patch is ext4 maintainer: "Theodore Ts'o" Since this is completely independent of anything else in this series, just submit the patch to him. Thanks! Honza > --- > fs/ext4/fsync.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c > index be1d89f..8c15642 100644 > --- a/fs/ext4/fsync.c > +++ b/fs/ext4/fsync.c > @@ -113,8 +113,6 @@ static int __sync_inode(struct inode *inode, int datasync) > * > * What we do is just kick off a commit and wait on it. This will snapshot the > * inode to disk. > - * > - * i_mutex lock is held when entering and exiting this function > */ > > int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) > -- > 1.7.11.7 > -- Jan Kara SUSE Labs, CR