From: Andrew Morton <akpm@linux-foundation.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
bug-track@fisher-privat.net
Subject: Re: [PATCH 2/2] fat: mark fs as dirty on mount and clean on umount
Date: Wed, 2 Jan 2013 15:44:22 -0800 [thread overview]
Message-ID: <20130102154422.53a84995.akpm@linux-foundation.org> (raw)
In-Reply-To: <87han7za23.fsf@devron.myhome.or.jp>
On Fri, 28 Dec 2012 02:20:20 +0900
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> There is no documented methods to mark FAT as dirty. Unofficially MS
> started to use reserved Byte in boot sector for this purpose,
> at least since Win 2000. With Win 7 user is warned if fs is dirty
> and asked to clean it.
> Different versions of Win, handle it in different ways,
> but always have same meaning:
> - Win 2000 and XP, set it on write operations and
> remove it after operation was finnished
> - Win 7, set dirty flag on first write and remove it on umount.
>
> We will do it as fallow:
> - set dirty flag on mount. If fs was initially dirty, warn user,
> remember it and do not do any changes to boot sector.
> - clean it on umount. If fs was initially dirty, leave it dirty.
> - do not do any thing if fs mounted read-only.
> - TODO: leave fs dirty if we found some error after mount.
The changelog doesn't describe why we're making this change. Nor does
it describe the user-visible effects of this change.
AFAICT the effect is to issue a warning at mount-time to tell the
user that the fs wasn't cleanly unmounted and that the user should fsck
the volume, correct?
If so, why is this considered a desirable feature? (I can guess, but
would prefer to hear it spelled out by the experts, please).
next prev parent reply other threads:[~2013-01-02 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 17:19 [PATCH 1/2] fat: add extended fileds to struct fat_boot_sector OGAWA Hirofumi
2012-12-27 17:20 ` [PATCH 2/2] fat: mark fs as dirty on mount and clean on umount OGAWA Hirofumi
2013-01-02 23:44 ` Andrew Morton [this message]
2013-01-03 8:46 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102154422.53a84995.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bug-track@fisher-privat.net \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).