[PATCH] vfs: Add missing errno.h inclusion to namei.h

[PATCH] vfs: Add missing errno.h inclusion to namei.h

[Mark Brown]

In current -next namei.h now include/linux/namei.h uses ESTALE but does
not include errno.h, leading to build failures on ARM where errno.h is
not previously implicitly included by some other header as is the case
in some bits of ext3. Fix this by adding a direct inclusion of errno.h.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 include/linux/namei.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..5a5ff57 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -2,6 +2,7 @@
 #define _LINUX_NAMEI_H
 
 #include <linux/dcache.h>
+#include <linux/errno.h>
 #include <linux/linkage.h>
 #include <linux/path.h>
 
-- 
1.7.10.4

Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h

[Jeff Layton]

On Wed,  2 Jan 2013 13:36:26 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> In current -next namei.h now include/linux/namei.h uses ESTALE but does
> not include errno.h, leading to build failures on ARM where errno.h is
> not previously implicitly included by some other header as is the case
> in some bits of ext3. Fix this by adding a direct inclusion of errno.h.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  include/linux/namei.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index e998c03..5a5ff57 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -2,6 +2,7 @@
>  #define _LINUX_NAMEI_H
>  
>  #include <linux/dcache.h>
> +#include <linux/errno.h>
>  #include <linux/linkage.h>
>  #include <linux/path.h>
>  

I think Ted and Stephen (cc'ed here) proposed the same patch a week or
so ago, but I'm not sure why Al hasn't pushed it yet.

-- 
Jeff Layton <jlayton@redhat.com>

Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On Wed, Jan 02, 2013 at 08:42:05AM -0500, Jeff Layton wrote:

> I think Ted and Stephen (cc'ed here) proposed the same patch a week or
> so ago, but I'm not sure why Al hasn't pushed it yet.

Well, a Christmas vacation isn't totally unreasonable...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h

[Al Viro]

On Wed, Jan 02, 2013 at 01:46:07PM +0000, Mark Brown wrote:
> On Wed, Jan 02, 2013 at 08:42:05AM -0500, Jeff Layton wrote:
> 
> > I think Ted and Stephen (cc'ed here) proposed the same patch a week or
> > so ago, but I'm not sure why Al hasn't pushed it yet.
> 
> Well, a Christmas vacation isn't totally unreasonable...

Arrgh...  My apologies - it had sat applied since 25th, but hadn't been
pushed and pull request hadn't been sent.  Linus, could you pull
git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

Shortlog:
Stephen Warren (1):
      namei.h: include errno.h

Diffstat:
 include/linux/namei.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)