* [PATCH] vfs: Add missing errno.h inclusion to namei.h
@ 2013-01-02 13:36 Mark Brown
2013-01-02 13:42 ` Jeff Layton
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2013-01-02 13:36 UTC (permalink / raw)
To: Al Viro, Jeff Layton; +Cc: linux-kernel, linux-fsdevel, Mark Brown
In current -next namei.h now include/linux/namei.h uses ESTALE but does
not include errno.h, leading to build failures on ARM where errno.h is
not previously implicitly included by some other header as is the case
in some bits of ext3. Fix this by adding a direct inclusion of errno.h.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
include/linux/namei.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/namei.h b/include/linux/namei.h
index e998c03..5a5ff57 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -2,6 +2,7 @@
#define _LINUX_NAMEI_H
#include <linux/dcache.h>
+#include <linux/errno.h>
#include <linux/linkage.h>
#include <linux/path.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h
2013-01-02 13:36 [PATCH] vfs: Add missing errno.h inclusion to namei.h Mark Brown
@ 2013-01-02 13:42 ` Jeff Layton
2013-01-02 13:46 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2013-01-02 13:42 UTC (permalink / raw)
To: Mark Brown
Cc: Al Viro, linux-kernel, linux-fsdevel, Stephen Warren,
Theodore Ts'o
On Wed, 2 Jan 2013 13:36:26 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> In current -next namei.h now include/linux/namei.h uses ESTALE but does
> not include errno.h, leading to build failures on ARM where errno.h is
> not previously implicitly included by some other header as is the case
> in some bits of ext3. Fix this by adding a direct inclusion of errno.h.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/namei.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index e998c03..5a5ff57 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -2,6 +2,7 @@
> #define _LINUX_NAMEI_H
>
> #include <linux/dcache.h>
> +#include <linux/errno.h>
> #include <linux/linkage.h>
> #include <linux/path.h>
>
I think Ted and Stephen (cc'ed here) proposed the same patch a week or
so ago, but I'm not sure why Al hasn't pushed it yet.
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h
2013-01-02 13:42 ` Jeff Layton
@ 2013-01-02 13:46 ` Mark Brown
2013-01-03 20:24 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2013-01-02 13:46 UTC (permalink / raw)
To: Jeff Layton
Cc: Al Viro, linux-kernel, linux-fsdevel, Stephen Warren,
Theodore Ts'o
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
On Wed, Jan 02, 2013 at 08:42:05AM -0500, Jeff Layton wrote:
> I think Ted and Stephen (cc'ed here) proposed the same patch a week or
> so ago, but I'm not sure why Al hasn't pushed it yet.
Well, a Christmas vacation isn't totally unreasonable...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h
2013-01-02 13:46 ` Mark Brown
@ 2013-01-03 20:24 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2013-01-03 20:24 UTC (permalink / raw)
To: Linus Torvalds
Cc: Jeff Layton, linux-kernel, linux-fsdevel, Stephen Warren,
Theodore Ts'o, Mark Brown
On Wed, Jan 02, 2013 at 01:46:07PM +0000, Mark Brown wrote:
> On Wed, Jan 02, 2013 at 08:42:05AM -0500, Jeff Layton wrote:
>
> > I think Ted and Stephen (cc'ed here) proposed the same patch a week or
> > so ago, but I'm not sure why Al hasn't pushed it yet.
>
> Well, a Christmas vacation isn't totally unreasonable...
Arrgh... My apologies - it had sat applied since 25th, but hadn't been
pushed and pull request hadn't been sent. Linus, could you pull
git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
Shortlog:
Stephen Warren (1):
namei.h: include errno.h
Diffstat:
include/linux/namei.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-03 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-02 13:36 [PATCH] vfs: Add missing errno.h inclusion to namei.h Mark Brown
2013-01-02 13:42 ` Jeff Layton
2013-01-02 13:46 ` Mark Brown
2013-01-03 20:24 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).