From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH 04/32] aio: remove retry-based AIO Date: Mon, 7 Jan 2013 14:12:19 -0800 Message-ID: <20130107221219.GC26407@google.com> References: <1356573611-18590-1-git-send-email-koverstreet@google.com> <1356573611-18590-5-git-send-email-koverstreet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, Zach Brown , bcrl@kvack.org, jmoyer@redhat.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, tytso@mit.edu To: Hillf Danton Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Dec 29, 2012 at 03:36:38PM +0800, Hillf Danton wrote: > On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet wrote: > > - /* > > - * This is so that aio_complete knows it doesn't need to > > - * pull the iocb off the run list (We can't just call > > - * INIT_LIST_HEAD because we don't want a kick_iocb to > > - * queue this on the run list yet) > > - */ > > - iocb->ki_run_list.next = iocb->ki_run_list.prev = NULL; > > The tricky, list.next = NULL, is erased here, but it is reused in one of > the subsequent patches, why? I think you're confusing the two different linked lists - there's ki_run_list, which isn't used anymore after this patch (and deleted here), and ki_list, which is used for cancellation. Yeah, it's tricky and ugly. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org