From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 13/17] fsfreeze: unfreeze bdevs in addition to filesystems during emergency thaw Date: Wed, 9 Jan 2013 17:41:24 +0100 Message-ID: <20130109164124.GF17353@quack.suse.cz> References: <1357557492.8183.1.camel@nexus.lab.ntt.co.jp> <1357558781.8183.20.camel@nexus.lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Al Viro , Josef Bacik , Eric Sandeen , Dave Chinner , Christoph Hellwig , Jan Kara , Luiz Capitulino , linux-fsdevel@vger.kernel.org To: Fernando Luis =?iso-8859-1?Q?V=E1zquez?= Cao Return-path: Received: from cantor2.suse.de ([195.135.220.15]:56362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932201Ab3AIQl0 (ORCPT ); Wed, 9 Jan 2013 11:41:26 -0500 Content-Disposition: inline In-Reply-To: <1357558781.8183.20.camel@nexus.lab.ntt.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 07-01-13 20:39:41, Fernando Luis V=E1zquez Cao wrote: > Now that sb-level/bdev-level fsfreeze integration has been achieved a= nd > sb-lebel/bdev-level freeze counters are always kept consistent, we ne= ed to > unfreeze bdevs in addition to filesystems during emergency thaw so th= at > we can recover from a situation where someone forgot to call thaw_bde= v(). Looks good. You can add: Reviewed-by: Jan Kara A typo fix below: > +void do_thaw_one_bdev(struct block_device *bdev, void *arg) > +{ > + struct super_block *sb; > + > + mutex_lock(&bdev->bd_fsfreeze_mutex); > + > + if (!bdev->bd_fsfreeze_count) { > + mutex_unlock(&bdev->bd_fsfreeze_mutex); > + return; > + } > + > + /* > + * We know the block device is frozen so we do not need to grab a > + * reference - the first call to thaw_bdev() dit it. ^^^ did -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html