From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: shilong wang <wangshilong1991@gmail.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] Ext3: add necessary check in case IO error happens
Date: Sat, 12 Jan 2013 15:30:50 -0500 [thread overview]
Message-ID: <20130112203050.GA10950@thunk.org> (raw)
In-Reply-To: <20130111162633.GD16923@quack.suse.cz>
On Fri, Jan 11, 2013 at 05:26:33PM +0100, Jan Kara wrote:
> Thanks for the patch. I think returning ENOMEM instead of EIO would be
> better. Otherwise the patch looks OK.
This may be because fs/ext4/inode.c was returning EIO in similar
circumstances. I agree ENOMEM is a better error code. I'll fix up
ext4....
- Ted
prev parent reply other threads:[~2013-01-12 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 11:58 [PATCH 2/2] Ext3: add necessary check in case IO error happens shilong wang
2013-01-11 16:26 ` Jan Kara
2013-01-12 2:20 ` shilong wang
2013-01-12 20:30 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130112203050.GA10950@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).