From: Theodore Ts'o <tytso@mit.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Wang shilong <wangshilong1991@gmail.com>,
jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] Ext3: return ENOMEM rather than EIO if sb_getblk fails
Date: Sun, 13 Jan 2013 22:45:38 -0500 [thread overview]
Message-ID: <20130114034538.GB29329@thunk.org> (raw)
In-Reply-To: <20130113044342.GA11738@kroah.com>
On Sat, Jan 12, 2013 at 08:43:42PM -0800, Greg KH wrote:
> On Thu, Jan 13, 2011 at 06:47:14PM +0800, Wang shilong wrote:
> > From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
> >
> > It will be better to have ENOMEM return rather than EIO,because
> > the only reason that sb_getblk fails is allocation fails.
> >
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
Did Wang Shilong bcc stable@vger.kernel.org? He didn't need to send
this to linux-fsdevel@vger.kernel.org (the linux-ext4 list is
sufficient), but I didn't see anything which indicated he was trying
to submit this for inclusion in the stable kernel tree.
My personal opinion is this isn't an important enough patch to warrant
going into stable@vger.kernel.org, although I don't think it would do
any harm or is really dangerous, so I wouldn't object strongly if it did.
I did mark a similar change for ext4 as going to stable, but not
because of the error code change; but rather because I also fixed a
problem where an out-of-memory failure might result in the file system
getting marked as containing errors (and thus might cause an unneeded
fsck).
Cheers,
- Ted
next prev parent reply other threads:[~2013-01-14 3:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 10:47 [PATCH 2/2] Ext3: return ENOMEM rather than EIO if sb_getblk fails Wang shilong
2011-01-14 2:57 ` apple
2013-01-13 4:43 ` Greg KH
2013-01-14 3:45 ` Theodore Ts'o [this message]
2013-01-14 3:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114034538.GB29329@thunk.org \
--to=tytso@mit.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
--cc=wangsl-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).