From: Jan Kara <jack@suse.cz>
To: James Hogan <james@albanarts.com>
Cc: Namjae Jeon <linkinjeon@gmail.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] NULL pointer dereference in udf_sb_free_partitions
Date: Mon, 14 Jan 2013 22:59:30 +0100 [thread overview]
Message-ID: <20130114215930.GA30482@quack.suse.cz> (raw)
In-Reply-To: <20130114210637.GA2122@balrog>
On Mon 14-01-13 21:06:37, James Hogan wrote:
> Hi,
>
> On Mon, Jan 14, 2013 at 02:19:39PM +0900, Namjae Jeon wrote:
> > There is missing exception handling in memory leak patch. (udf: Fix
> > memory leak when mounting)
> > So, Would you try to reproduce this problem with the below patch ?
> >
> > Thanks.
> >
> > ---------------------------------------------------------------------------
> > Subject: [PATCH] UDF: Fix a null pointer dereference in udf_sb_free_partitions
> >
> > This patch fixes a regression caused by commit bff943af6fe
> > "udf: Fix memory leak when mounting" due to which it was triggering
> > a kernel null point dereference in case of mount failed OR when allocating
> > memory to sbi->s_partmaps failed in function udf_sb_alloc_partition_maps.
> >
> > Reported-by: James Hogan <james@albanarts.com>
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
>
> v3.8-rc3 + your patch no longer crashes.
>
> Tested-by: James Hogan <james@albanarts.com>
Thanks for confirmation. I've added the fix to my tree and will push it
to Linus soon.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-01-14 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 22:00 [BUG] NULL pointer dereference in udf_sb_free_partitions James Hogan
2013-01-14 5:19 ` Namjae Jeon
2013-01-14 15:18 ` Jan Kara
2013-01-14 21:06 ` James Hogan
2013-01-14 21:59 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114215930.GA30482@quack.suse.cz \
--to=jack@suse.cz \
--cc=james@albanarts.com \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).