From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [BUG] NULL pointer dereference in udf_sb_free_partitions Date: Mon, 14 Jan 2013 22:59:30 +0100 Message-ID: <20130114215930.GA30482@quack.suse.cz> References: <20130112220015.GA2387@balrog> <20130114210637.GA2122@balrog> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Namjae Jeon , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: James Hogan Return-path: Content-Disposition: inline In-Reply-To: <20130114210637.GA2122@balrog> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon 14-01-13 21:06:37, James Hogan wrote: > Hi, > > On Mon, Jan 14, 2013 at 02:19:39PM +0900, Namjae Jeon wrote: > > There is missing exception handling in memory leak patch. (udf: Fix > > memory leak when mounting) > > So, Would you try to reproduce this problem with the below patch ? > > > > Thanks. > > > > --------------------------------------------------------------------------- > > Subject: [PATCH] UDF: Fix a null pointer dereference in udf_sb_free_partitions > > > > This patch fixes a regression caused by commit bff943af6fe > > "udf: Fix memory leak when mounting" due to which it was triggering > > a kernel null point dereference in case of mount failed OR when allocating > > memory to sbi->s_partmaps failed in function udf_sb_alloc_partition_maps. > > > > Reported-by: James Hogan > > Signed-off-by: Namjae Jeon > > Signed-off-by: Ashish Sangwan > > v3.8-rc3 + your patch no longer crashes. > > Tested-by: James Hogan Thanks for confirmation. I've added the fix to my tree and will push it to Linus soon. Honza -- Jan Kara SUSE Labs, CR