linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: axboe@kernel.dk, lucho@ionkov.net, jack@suse.cz,
	ericvh@gmail.com, tytso@mit.edu, viro@zeniv.linux.org.uk,
	rminnich@sandia.gov, martin.petersen@oracle.com, neilb@suse.de,
	Mark Fasheh <mfasheh@suse.com>,
	david@fromorbit.com, gnehzuil.liu@gmail.com,
	linux-kernel@vger.kernel.org, hch@infradead.org,
	linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca,
	ocfs2-devel@oss.oracle.com, bharrosh@panasas.com,
	jlayton@samba.org, linux-ext4@vger.kernel.org,
	hirofumi@mail.parknet.co.jp, Joel Becker <jlbec@evilplan.org>
Subject: Re: [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
Date: Tue, 15 Jan 2013 11:15:06 +0100	[thread overview]
Message-ID: <20130115101506.GB1778@quack.suse.cz> (raw)
In-Reply-To: <20130115054313.1563.70148.stgit@blackbox.djwong.org>

On Mon 14-01-13 21:43:13, Darrick J. Wong wrote:
> When stable pages are required, we have to wait if the page is just
> going to disk and we want to modify it. Add proper callback to
> ocfs2_grab_pages_for_write().
> 
> CC: ocfs2-devel@oss.oracle.com
> CC: Joel Becker <jlbec@evilplan.org>
> CC: Mark Fasheh <mfasheh@suse.com>
> From: Jan Kara <jack@suse.cz>
> Signed-off-by: Jan Kara <jack@suse.cz>
  Darrick, to satisfy the kernel patch submission process you should also
add your Signed-off-by to the patch...

								Honza
> ---
>  fs/ocfs2/aops.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
> index 6577432..9796330 100644
> --- a/fs/ocfs2/aops.c
> +++ b/fs/ocfs2/aops.c
> @@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping,
>  				goto out;
>  			}
>  		}
> +		wait_for_stable_page(wc->w_pages[i]);
>  
>  		if (index == target_index)
>  			wc->w_target_page = wc->w_pages[i];
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2013-01-15 10:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  5:42 [PATCH v2.4 0/3] mm/fs: Remove unnecessary waiting for stable pages Darrick J. Wong
2013-01-15  5:42 ` [PATCH 1/6] bdi: Allow block devices to say that they require stable page writes Darrick J. Wong
2013-01-15  5:42 ` [PATCH 2/6] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2013-01-15 10:19   ` Jan Kara
2013-01-15 10:59   ` Steven Whitehouse
2013-01-18  1:26     ` Darrick J. Wong
2013-01-15  5:42 ` [PATCH 3/6] 9pfs: Fix filesystem to wait for stable page writeback Darrick J. Wong
2013-01-15  5:43 ` [PATCH 4/6] block: Optionally snapshot page contents to provide stable pages during write Darrick J. Wong
2013-01-16  2:00   ` Jan Kara
2013-01-17  3:01     ` Darrick J. Wong
2013-01-17  3:26       ` Martin K. Petersen
2013-01-17 10:32       ` Jan Kara
2013-01-15  5:43 ` [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages Darrick J. Wong
2013-01-15 10:15   ` Jan Kara [this message]
2013-01-15  5:43 ` [PATCH 6/6] ubifs: " Darrick J. Wong
2013-01-15 22:46 ` [PATCH v2.4 0/3] mm/fs: Remove unnecessary waiting for " Andrew Morton
2013-01-16  0:22   ` Darrick J. Wong
2013-01-16  0:33     ` Andrew Morton
2013-01-17  2:49       ` Darrick J. Wong
2013-01-17  4:43         ` Andrew Morton
2013-01-18  1:18           ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2013-01-19  1:12 [PATCH v2.5 " Darrick J. Wong
2013-01-19  1:13 ` [PATCH 5/6] ocfs2: Wait for page writeback to provide " Darrick J. Wong
2013-01-30  1:03   ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130115101506.GB1778@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=bharrosh@panasas.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=ericvh@gmail.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=hch@infradead.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jlayton@samba.org \
    --cc=jlbec@evilplan.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=martin.petersen@oracle.com \
    --cc=mfasheh@suse.com \
    --cc=neilb@suse.de \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rminnich@sandia.gov \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).