From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Maiolino Subject: Re: [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry() Date: Tue, 22 Jan 2013 06:41:30 -0500 Message-ID: <20130122114130.GA30041@localhost.localdomain> References: <1358819251-3355-1-git-send-email-sedat.dilek@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dave Kleikamp , Zach Brown , "Maxim V. Patlasov" , Jeff Moyer , Alexander Viro , linux-fsdevel@vger.kernel.org To: Sedat Dilek Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25218 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430Ab3AVLlp (ORCPT ); Tue, 22 Jan 2013 06:41:45 -0500 Content-Disposition: inline In-Reply-To: <1358819251-3355-1-git-send-email-sedat.dilek@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jan 22, 2013 at 02:47:31AM +0100, Sedat Dilek wrote: > Dave confirmed Jeff's suspicion in [1]: > > >> That wants to be rw_op = do_aio_write in the else clause. How did you > >> test this patch set? > > > Yep, that's certainly a bug. I concentrated on testing on loop mounts, > > running some fio and ltp testcases, but I'm at a loss to explain how > > things seem to work as well as they do. Let's see how where fixing this > > leads. > > This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter > rather than aio_read and aio_write") from Dave Kleikamp's GIT tree in [2]. > > [1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html > [2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04 > > Cc: Dave Kleikamp > Cc: Jeff Moyer > Cc: Alexander Viro > Cc: linux-fsdevel@vger.kernel.org > [ v2: Misspelled Dave's last name and fix quoting. ] > Signed-off-by: Sedat Dilek > --- > fs/aio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 08f550a..9635e7a 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb) > rw_op = do_aio_read; > opcode = IOCB_CMD_PREADV; > } else { > - rw_op = do_aio_read; > + rw_op = do_aio_write; > opcode = IOCB_CMD_PWRITEV; > } > Looks Good, Reviewed-by: Carlos Maiolino > -- > 1.8.1.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos