From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aristeu Rozanski Subject: Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap. Date: Mon, 28 Jan 2013 10:12:44 -0500 Message-ID: <20130128151244.GV17632@redhat.com> References: <87ehh8it9s.fsf@xmission.com> <87zjzwhegj.fsf@xmission.com> <20130128142816.GU17632@redhat.com> <51068E23.5040000@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , "Eric W. Biederman" , Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lord Glauber Costa of Sealand Return-path: Content-Disposition: inline In-Reply-To: <51068E23.5040000-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jan 28, 2013 at 06:41:39PM +0400, Lord Glauber Costa of Sealand wrote: > Hello Mr. Someone. > > On 01/28/2013 06:28 PM, Aristeu Rozanski wrote: > > On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: > >> When I initially wrote the code for /proc//uid_map. I was lazy > >> and avoided duplicate mappings by the simple expedient of ensuring the > >> first number in a new extent was greater than any number in the > >> previous extent. > >> > >> Unfortunately that precludes a number of valid mappings, and someone > >> noticed and complained. So use a simple check to ensure that ranges > >> in the mapping extents don't overlap. > > > > Acked-by: Someone > > > > Documentation/SubmittingPatches: > > "then you just add a line saying > > Signed-off-by: Random J Developer > > using your real name (sorry, no pseudonyms or anonymous contributions.)" > > I know how it feels, but that is how it goes. You'll have to change that. oh well, another trip to the social security office and DMV. -- Aristeu