From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] vfs: set s_type in alloc_super()
Date: Wed, 30 Jan 2013 15:08:26 +0000
Message-ID: <20130130150826.GL4503@ZenIV.linux.org.uk>
References: <1359504971-20153-1-git-send-email-jlayton@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com
To: Jeff Layton <jlayton@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:49781 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751438Ab3A3PI1 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 30 Jan 2013 10:08:27 -0500
Content-Disposition: inline
In-Reply-To: <1359504971-20153-1-git-send-email-jlayton@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jan 29, 2013 at 07:16:11PM -0500, Jeff Layton wrote:
> I see no reason to wait until after the "set" operation returns to set
> the s_type. We do call destroy_super() in some cases with that value
> unset. That seems to be OK in almost all cases, but we had a fire-drill
> recently with some RHEL-only patches that oopsed because the s_type was
> unset when destroy_super() got called.
> 
> Move the setting of the s_type into alloc_super() as a defensive coding
> measure.

	NAK.  If anything, I'm seriously tempted to zero ->s_type in
deactivate_locked_super() just before we do put_filesystem_type() and
that reference becomes garbage.