From: Al Viro <viro@ZenIV.linux.org.uk>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
Dave Kleikamp <shaggy@kernel.org>
Subject: [RFC] setxattr bugs
Date: Sun, 3 Feb 2013 04:30:46 +0000 [thread overview]
Message-ID: <20130203043046.GR4503@ZenIV.linux.org.uk> (raw)
* JFS, since 2005: setxattr(name, "system.posix_acl_access", NULL, 0, 0)
succeeds, creating an empty EA with "system.posix_acl_access" as name.
Validity checks should apply _after_
if (value == NULL) { /* empty EA, do not remove */
value = "";
value_len = 0;
}
and not before it.
* reiserfs, since 2009: setxattr(name, attr_name, NULL, 0, 0) is
treated as removexattr(name, attr_name), not as emptying given xattr.
The question is, does either of those cross into "established
weirdness in ABI" or are they still at the "bugs to be fixed" stage?
FWIW, I'm seriously tempted to stop passing NULL as the
third argument of ->setxattr(), essentially taking all those
if (!value) value = ""; pieces from individual ->setxattr() instances
to __vfs_setxattr_noperm() (all other callers of ->setxattr() never
pass NULL data or 0 size, so it's irrelevant for them). Would fix
both jfs and reiserfs weirdness....
Objections?
next reply other threads:[~2013-02-03 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 4:30 Al Viro [this message]
2013-02-03 13:59 ` [RFC] setxattr bugs Dave Kleikamp
2013-02-05 2:14 ` Jeff Mahoney
2013-02-05 17:14 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203043046.GR4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jeffm@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).