linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES
@ 2013-02-05  1:04 Jeff Mahoney
  2013-02-05 11:29 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Mahoney @ 2013-02-05  1:04 UTC (permalink / raw)
  To: Linux FS Maling List, Jan Kara; +Cc: stable

Commit 498c6015 (quota: Implement quota format with 64-bit space
and inode limits) added the vfsv1 quota format but didn't add it
to INIT_QUOTA_MODULE_NAMES.

File systems using QFMT_VFS_V1 format quotas with CONFIG_QFMT_V1=m,
will fail to enable quotas with ESRCH because the module won't be
loaded.

This patch adds it to the list.

Cc: <stable@vger.kernel.org> [>=2.6.33]
Cc: Jan Kara <jack@suse.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 include/linux/quota.h |    1 +
 1 file changed, 1 insertion(+)

--- a/include/linux/quota.h
+++ b/include/linux/quota.h
@@ -405,6 +405,7 @@ struct quota_module_name {
 #define INIT_QUOTA_MODULE_NAMES {\
 	{QFMT_VFS_OLD, "quota_v1"},\
 	{QFMT_VFS_V0, "quota_v2"},\
+	{QFMT_VFS_V1, "quota_v2"},\
 	{0, NULL}}
 
 #endif /* _QUOTA_ */

-- 
Jeff Mahoney
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES
  2013-02-05  1:04 [PATCH] quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES Jeff Mahoney
@ 2013-02-05 11:29 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-02-05 11:29 UTC (permalink / raw)
  To: Jeff Mahoney; +Cc: Linux FS Maling List, Jan Kara, stable

On Mon 04-02-13 20:04:40, Jeff Mahoney wrote:
> Commit 498c6015 (quota: Implement quota format with 64-bit space
> and inode limits) added the vfsv1 quota format but didn't add it
> to INIT_QUOTA_MODULE_NAMES.
> 
> File systems using QFMT_VFS_V1 format quotas with CONFIG_QFMT_V1=m,
> will fail to enable quotas with ESRCH because the module won't be
> loaded.
> 
> This patch adds it to the list.
> 
> Cc: <stable@vger.kernel.org> [>=2.6.33]
> Cc: Jan Kara <jack@suse.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
  Thanks for the patch. Ted Tso actually found the problem few days ago as
well and is carrying the fix in his tree. So this should get fixed once the
next merge window opens.

								Honza
> ---
>  include/linux/quota.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -405,6 +405,7 @@ struct quota_module_name {
>  #define INIT_QUOTA_MODULE_NAMES {\
>  	{QFMT_VFS_OLD, "quota_v1"},\
>  	{QFMT_VFS_V0, "quota_v2"},\
> +	{QFMT_VFS_V1, "quota_v2"},\
>  	{0, NULL}}
>  
>  #endif /* _QUOTA_ */
> 
> -- 
> Jeff Mahoney
> SUSE Labs
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-05 11:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-05  1:04 [PATCH] quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES Jeff Mahoney
2013-02-05 11:29 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).