From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES Date: Tue, 5 Feb 2013 12:29:45 +0100 Message-ID: <20130205112945.GA5943@quack.suse.cz> References: <51105AA8.70305@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux FS Maling List , Jan Kara , stable@vger.kernel.org To: Jeff Mahoney Return-path: Received: from cantor2.suse.de ([195.135.220.15]:45151 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715Ab3BEL3t (ORCPT ); Tue, 5 Feb 2013 06:29:49 -0500 Content-Disposition: inline In-Reply-To: <51105AA8.70305@suse.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 04-02-13 20:04:40, Jeff Mahoney wrote: > Commit 498c6015 (quota: Implement quota format with 64-bit space > and inode limits) added the vfsv1 quota format but didn't add it > to INIT_QUOTA_MODULE_NAMES. > > File systems using QFMT_VFS_V1 format quotas with CONFIG_QFMT_V1=m, > will fail to enable quotas with ESRCH because the module won't be > loaded. > > This patch adds it to the list. > > Cc: [>=2.6.33] > Cc: Jan Kara > Signed-off-by: Jeff Mahoney Thanks for the patch. Ted Tso actually found the problem few days ago as well and is carrying the fix in his tree. So this should get fixed once the next merge window opens. Honza > --- > include/linux/quota.h | 1 + > 1 file changed, 1 insertion(+) > > --- a/include/linux/quota.h > +++ b/include/linux/quota.h > @@ -405,6 +405,7 @@ struct quota_module_name { > #define INIT_QUOTA_MODULE_NAMES {\ > {QFMT_VFS_OLD, "quota_v1"},\ > {QFMT_VFS_V0, "quota_v2"},\ > + {QFMT_VFS_V1, "quota_v2"},\ > {0, NULL}} > > #endif /* _QUOTA_ */ > > -- > Jeff Mahoney > SUSE Labs -- Jan Kara SUSE Labs, CR