From: Mel Gorman <mgorman@suse.de>
To: Michel Lespinasse <walken@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lin Feng <linfeng@cn.fujitsu.com>,
bcrl@kvack.org, viro@zeniv.linux.org.uk, khlebnikov@openvz.org,
kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
riel@redhat.com, rientjes@google.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, jiang.liu@huawei.com, linux-mm@kvack.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()
Date: Wed, 6 Feb 2013 10:41:17 +0000 [thread overview]
Message-ID: <20130206104117.GO21389@suse.de> (raw)
In-Reply-To: <CANN689GVFYTqs0wxX3bKZtyBcWf6=gLvS8hFG-65htsnPDknSA@mail.gmail.com>
On Tue, Feb 05, 2013 at 06:26:51PM -0800, Michel Lespinasse wrote:
> Just nitpicking, but:
>
> On Tue, Feb 5, 2013 at 3:57 AM, Mel Gorman <mgorman@suse.de> wrote:
> > +static inline bool zone_is_idx(struct zone *zone, enum zone_type idx)
> > +{
> > + /* This mess avoids a potentially expensive pointer subtraction. */
> > + int zone_off = (char *)zone - (char *)zone->zone_pgdat->node_zones;
> > + return zone_off == idx * sizeof(*zone);
> > +}
>
> Maybe:
> return zone == zone->zone_pgdat->node_zones + idx;
> ?
>
Not a nit at all. Yours is more readable but it generates more code. A
single line function that uses the helper generates 0x3f bytes of code
(mostly function entry/exit) with your version and 0x39 bytes with mine. The
difference in efficiency is marginal as your version uses lea to multiply
by a constant but it's still slightly heavier.
The old code is fractionally better, your version is more readable so it's
up to Andrew really. Right now I think he's gone with his own version with
zone_idx() in the name of readability whatever sparse has to say about
the matter.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-06 10:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 10:04 [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Lin Feng
2013-02-04 10:04 ` [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable() Lin Feng
2013-02-05 0:06 ` Andrew Morton
2013-02-05 0:18 ` Andrew Morton
2013-02-05 3:09 ` Lin Feng
2013-02-05 21:13 ` Andrew Morton
2013-02-05 11:57 ` Mel Gorman
2013-02-05 13:32 ` Mel Gorman
2013-02-19 13:37 ` Lin Feng
2013-02-20 2:34 ` Lin Feng
2013-02-20 2:44 ` Wanpeng Li
2013-02-20 2:44 ` Wanpeng Li
[not found] ` <20130220024435.GA30208@hacker.(null)>
2013-02-20 2:59 ` Lin Feng
2013-02-20 9:58 ` Simon Jeons
2013-02-20 10:23 ` Lin Feng
2013-02-20 11:31 ` Simon Jeons
2013-02-20 11:54 ` Lin Feng
2013-02-06 2:26 ` Michel Lespinasse
2013-02-06 10:41 ` Mel Gorman [this message]
2013-02-18 10:34 ` Lin Feng
2013-02-18 15:17 ` Mel Gorman
2013-02-19 9:55 ` Lin Feng
2013-02-19 10:34 ` Mel Gorman
2013-02-04 10:04 ` [PATCH 2/2] fs/aio.c: use get_user_pages_non_movable() to pin ring pages when support memory hotremove Lin Feng
2013-02-04 15:18 ` Jeff Moyer
2013-02-04 23:02 ` Zach Brown
2013-02-05 5:35 ` Lin Feng
2013-02-05 5:06 ` Lin Feng
2013-02-05 0:58 ` [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Minchan Kim
2013-02-05 4:42 ` Lin Feng
2013-02-05 5:25 ` Minchan Kim
2013-02-05 6:18 ` Lin Feng
2013-02-05 7:45 ` Minchan Kim
2013-02-05 8:27 ` Lin Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206104117.GO21389@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).